-
Notifications
You must be signed in to change notification settings - Fork 17
Remove explicit Qt dependency from rviz plugins #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Luca Della Vedova <[email protected]>
|
This is currently introducing a regression on rmf_visualization in Rolling, which pops up all the way to rmf_demos https://discourse.openrobotics.org/t/preparing-for-rolling-sync-2026-01-16/51785. I tested this PR in Rolling + testing and it seems to build fine, if anyone else wants to test it the procedure would be:
Without the PR Rolling should fail, with it should be OK |
Signed-off-by: Luca Della Vedova <[email protected]>
|
Tested with the two approaches suggested:
Can confirm that the build works for both! I'm able to run the usual demos in Jazzy. However gz keeps crashing if I try to run demos in Rolling - can't tell if that is expected behavior or not. Either way the build issue for rviz seems to be fixed, as it was able to launch properly. |
Ah good find, it seems to be a very hairy issue with launch substitutions for the headless parameter, I'll try to figure out whether it can be fixed either in |
aaronchongth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reference PR upstream, this makes a lot of sense now
Verified with open-rmf/rmf_demos#344, sim and plugins are working
|
I ran into a build issue while testing this out, although it's not the fault of this PR, nor anything we can fix within I've made a comment describing the problem on the issue ticket related to dropping Qt5. If we see users complaining that |
Bug fix
Fixed bug
Closes #87, depends on upstream
rviz_commonPR ros2/rviz#1635.Fix builds for rolling.
We should probably wait for the upstream PR to be merged and a Rolling sync to happen before merging this.
Fix applied
Since we want to keep this building with both Rolling, Lyrical and future versions, but also not break the old versions, don't explicitly depend on Qt5 or Qt6 and just depend on
rviz_commoninstead, which willfind_packagethe right version of Qt depending on the platform.Seems to build and run correctly in my local tests on a Noble + Jazzy and Noble + Rolling machine with the linked
rviz2branch to build from source.GenAI Use
We follow OSRA's policy on GenAI tools