Skip to content

Conversation

@luca-della-vedova
Copy link
Member

@luca-della-vedova luca-della-vedova commented Dec 4, 2025

Bug fix

Fixed bug

Closes #87, depends on upstream rviz_common PR ros2/rviz#1635.
Fix builds for rolling.
We should probably wait for the upstream PR to be merged and a Rolling sync to happen before merging this.

Fix applied

Since we want to keep this building with both Rolling, Lyrical and future versions, but also not break the old versions, don't explicitly depend on Qt5 or Qt6 and just depend on rviz_common instead, which will find_package the right version of Qt depending on the platform.

Seems to build and run correctly in my local tests on a Noble + Jazzy and Noble + Rolling machine with the linked rviz2 branch to build from source.

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

@mxgrey mxgrey added this to PMC Board Dec 4, 2025
@luca-della-vedova luca-della-vedova marked this pull request as draft December 4, 2025 02:46
@github-project-automation github-project-automation bot moved this to Inbox in PMC Board Dec 4, 2025
@luca-della-vedova luca-della-vedova marked this pull request as ready for review December 4, 2025 02:46
@luca-della-vedova luca-della-vedova marked this pull request as draft December 4, 2025 02:47
@mxgrey mxgrey moved this from Inbox to In Progress in PMC Board Dec 16, 2025
@luca-della-vedova luca-della-vedova marked this pull request as ready for review January 13, 2026 01:58
@luca-della-vedova
Copy link
Member Author

This is currently introducing a regression on rmf_visualization in Rolling, which pops up all the way to rmf_demos https://discourse.openrobotics.org/t/preparing-for-rolling-sync-2026-01-16/51785.

I tested this PR in Rolling + testing and it seems to build fine, if anyone else wants to test it the procedure would be:

  • Try it under Jazzy to make sure there are no regressions.
  • Try it under the upcoming Rolling binary packages by enabling ros2-testing as documented here

Without the PR Rolling should fail, with it should be OK

Signed-off-by: Luca Della Vedova <[email protected]>
@xiyuoh
Copy link
Member

xiyuoh commented Jan 13, 2026

Tested with the two approaches suggested:

  • with a Jazzy distrobox
  • with a Rolling distrobox, then enabling ros2-testing

Can confirm that the build works for both! I'm able to run the usual demos in Jazzy. However gz keeps crashing if I try to run demos in Rolling - can't tell if that is expected behavior or not. Either way the build issue for rviz seems to be fixed, as it was able to launch properly.

@luca-della-vedova
Copy link
Member Author

However gz keeps crashing if I try to run demos in Rolling - can't tell if that is expected behavior or not. Either way the build issue for rviz seems to be fixed, as it was able to launch properly.

Ah good find, it seems to be a very hairy issue with launch substitutions for the headless parameter, I'll try to figure out whether it can be fixed either in rmf_demos or upstream

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reference PR upstream, this makes a lot of sense now
Verified with open-rmf/rmf_demos#344, sim and plugins are working

@luca-della-vedova luca-della-vedova merged commit 140e0cc into main Jan 13, 2026
2 checks passed
@luca-della-vedova luca-della-vedova deleted the luca/remove_explicit_qt branch January 13, 2026 07:57
@github-project-automation github-project-automation bot moved this from In Progress to Done in PMC Board Jan 13, 2026
@mxgrey
Copy link
Contributor

mxgrey commented Jan 13, 2026

I ran into a build issue while testing this out, although it's not the fault of this PR, nor anything we can fix within rmf_visualization. It seems to be a faulty config-file in rviz.

I've made a comment describing the problem on the issue ticket related to dropping Qt5. If we see users complaining that rmf_visualization is no longer building, we will probably need to advise them to uninstall Qt5 until this gets resolved upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: rmf_visualization_rviz2_plugins fails building in Rolling

5 participants